Skip to content

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 22, 2022

Fixes a bug when beta-reducing inlined code. In some situations
the beta-reduction did not bind mutable variables.

@nicolasstucki nicolasstucki self-assigned this Nov 22, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from bfd295a to 7b769d2 Compare November 23, 2022 14:20
nicolasstucki added a commit to dotty-staging/spire that referenced this pull request Nov 25, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch 2 times, most recently from 2643ea2 to e0ac044 Compare November 25, 2022 16:37
@nicolasstucki nicolasstucki changed the title Reuse beta reduction logic from Beta-reduce Reuse beta reduction logic from BetaReduce Nov 25, 2022
@nicolasstucki nicolasstucki removed their assignment Nov 25, 2022
@nicolasstucki nicolasstucki marked this pull request as ready for review November 25, 2022 18:20
nicolasstucki added a commit to dotty-staging/spire that referenced this pull request Nov 28, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from e0ac044 to a83441c Compare November 28, 2022 08:13
Fixes a bug when beta-reducing inlined code. In some situations
the beta-reduction did not bind mutable variables.
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from a83441c to 7558d27 Compare November 28, 2022 11:19
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@odersky odersky merged commit 8fba321 into scala:main Nov 28, 2022
@odersky odersky deleted the reuse-beta-reduction-logic-from-betaReduce branch November 28, 2022 16:00
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Gedochao added a commit to Gedochao/dotty that referenced this pull request Sep 29, 2025
Fix val parameter override problem
v0.2.1 -- fix potential IDB API issue
dep: update a whole bunch of things (scala#71)

This pr updates the following:

  - various dependencies to the latest
  - adds in dependabot
  - updates java and checkout actions
  - updates ammonite scripts and uses new ammonite in CI
  - updates mill to the latest 0.10.5
  - bumps scalajs to 1.x
  - corrects repo location in pomSettings
Merge pull request scala#4238 from armanbilge/issue/4229

Build docs on 2.13
Merge pull request scala#350 from typelevel/update/sbt-typelevel-0.4.13

Update sbt-typelevel to 0.4.13
Merge pull request scala#187 from typelevel/update/sbt-typelevel-0.4.13

Update sbt-typelevel to 0.4.13
Merge pull request scala#318 from scala-steward/update/sbt-typelevel-0.4.3

Update sbt-typelevel, sbt-typelevel-site to 0.4.3
fix http4s output encoding to UTF-8 (scala#900)

support scala 3.0.0
Migrate to sbt slash syntax
Merge pull request scala#2951 from pchlupacek/patch-1

Update adopters.md
Adapt to new restrictions in fewerBraces
wip: cleanups
Reduce program size in one of the tests to decrease the chance of stack overflow.
v4.6.0
Update scalafmt-core to 3.4.0
Remove import suggestions from assertions
Clarify the unit of proc().call() 'timeout' parameter (scala#107)

Pull request: com-lihaoyi/os-lib#107
Setting version to 2.4.1-SNAPSHOT
Update auxlib, javalib, junit-plugin, ... to 0.4.3
Update serialization base64 for new lazy vals
Merge pull request scala#616 from SethTisue/enable-scala-3-publishing

Disable ExpectationsSpecs message tests
Fix test for change in union type inference
empty
Merge pull request scala#380 from scala-steward/update/sbt-typelevel-0.4.3

Update sbt-typelevel to 0.4.3
Update scalafmt-core to 3.7.12 (scala#163)

Co-authored-by: typelevel-steward[bot] <106827141+typelevel-steward[bot]@users.noreply.github.com>
test: use the same line numbers in the location spec

regardless of the scala compiler version
Disable buggy test

See scala#16390
New reference compiler is Scala 2.13.12
deps: update a bunch of things (scala#395)

* deps: update a bunch of things

This updates the following:

  - make sure Mill is on the latest 0.10.5
  - drops support for scalajs 0.x
  - bumps to the latest scala patch versions
  - bumps to the latest scalaJS and scala native
  - bumps to 0.8.0 of utest
  - adds in dependabot
  - adds in cross testing jdk for 8 and 17
  - bumps version of checkout and java actions

* refactor: restructure build to actually build

* fix: make mima happy by updating
Merge pull request scala#264 from scala-steward/update/test-interface-0.4.7

Update test-interface to 0.4.7
Merge pull request scala#183 from scala-steward/update/auxlib-0.4.3

Update auxlib, javalib, nativelib, nscplugin, ... to 0.4.3
Revert "Fix tests to work with changes after scala#15569"

This reverts commit 912b4f887912792202aa76e93fd19e63bd62f3bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants